Skip to content

v2.15.0#1663

Merged
prafull-opensignlabs merged 1 commit into
stagingfrom
updates-14122971328
Mar 28, 2025
Merged

v2.15.0#1663
prafull-opensignlabs merged 1 commit into
stagingfrom
updates-14122971328

Conversation

@nxglabs
Copy link
Copy Markdown
Collaborator

@nxglabs nxglabs commented Mar 28, 2025

v2.15.0

@prafull-opensignlabs
v2.15.0
ac8ab70 
v2.15.0
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-sign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 6:03am

github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 28, 2025
View reviewed changes
Comment thread apps/OpenSignServer/cloud/parsefunction/sendMailv3.js
resolve('error');
});
} else {
const httpsAgent = new https.Agent({ rejectUnauthorized: false }); // Disable SSL validation

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.

Copilot Autofix

AI about 1 year ago

To fix the problem, we need to ensure that certificate validation is not disabled. This can be done by removing the rejectUnauthorized: false option or setting it to true. This change will ensure that only trusted certificates are accepted, thereby maintaining the security of the TLS connection.

In the specific code snippet provided, we should modify the creation of the https.Agent to ensure that rejectUnauthorized is set to true. This change should be made in the sendMailProvider function within the sendMailv3.js file.

Suggested changeset 1
apps/OpenSignServer/cloud/parsefunction/sendMailv3.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/OpenSignServer/cloud/parsefunction/sendMailv3.js b/apps/OpenSignServer/cloud/parsefunction/sendMailv3.js
--- a/apps/OpenSignServer/cloud/parsefunction/sendMailv3.js
+++ b/apps/OpenSignServer/cloud/parsefunction/sendMailv3.js
@@ -51,3 +51,3 @@
             } else {
-              const httpsAgent = new https.Agent({ rejectUnauthorized: false }); // Disable SSL validation
+              const httpsAgent = new https.Agent({ rejectUnauthorized: true }); // Enable SSL validation
               axios
EOF
@@ -51,3 +51,3 @@
} else {
const httpsAgent = new https.Agent({ rejectUnauthorized: false }); // Disable SSL validation
const httpsAgent = new https.Agent({ rejectUnauthorized: true }); // Enable SSL validation
axios
Copilot is powered by AI and may make mistakes. Always verify output.
@prafull-opensignlabs prafull-opensignlabs merged commit fca45ce into staging Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prafull-opensignlabs prafull-opensignlabs prafull-opensignlabs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nxglabs @github-advanced-security @prafull-opensignlabs